Merge NixOS support (#2)#309
Merged
robwoolley merged 25 commits intoros-infrastructure:masterfrom Jan 20, 2025
Merged
Conversation
The CI system picked up non-conformance issues with recent changes to the ebuild generator. Fix lines that exceed 79 characters and remove an used chunk_count variable. Signed-off-by: Rob Woolley <rob.woolley@windriver.com>
This makes Nix package generation nearly 4 times faster, if tarballs are already cached. Some of the optimizations also apply to other distros, but the performance impact there was not tested.
GitLab returns a 403 error if the default urllib user agent is used.
This allows conditions in package.xml to be evaluated correctly. Mostly copied from the Bitbake generator.
This is required to make strictDeps/cross-compilation work.
This name better represents what this class does, which is to generate the actual text of a Nix expression for a package.
The license translation logic has changed, and adds a hyphen to unknown licenses. Also, add a test for the public domain license.
When --all is specified, generate for rolling as well.
The license string in the generated nix package file was broken when the license name contained quote. It has been fixed. Backslash and the sequence "dollar opening bracket" have been escaped too.
Use the same function to escape the description string as is used for the license string.
nuclearsandwich
approved these changes
Jan 20, 2025
Contributor
nuclearsandwich
left a comment
nuclearsandwich
left a comment
There was a problem hiding this comment.
I didn't perform an exhaustive review; preferring to leave that to the superflore maintainers. But I did review the changes from the upstream and do a quick scan of the added files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NixOS is used by Clearpath Robotics and other developers. The creator of the NixOS support expressed interest in merging the changes upstream. The work has been tested with the following commands:
git clone https://github.com/lopsided98/nix-ros-overlay $HOME/nix-ros-overlay
superflore-gen-nix
--output-repository-path $HOME/nix-ros-overlay
--upstream-branch develop
--all
--dry-run
This second PR differs in that it is rebased on a commit that provides pep8 fixes that allow the CI to pass.