Fixes for --pr-only support in the NixOS generator#326
Merged
robwoolley merged 2 commits intoros-infrastructure:masterfrom Oct 1, 2025
Merged
Fixes for --pr-only support in the NixOS generator#326robwoolley merged 2 commits intoros-infrastructure:masterfrom
robwoolley merged 2 commits intoros-infrastructure:masterfrom
Conversation
Contributor
|
Thanks @wentasah! I would be happy to merge this in. The CI picked up an error when running pyflakes: Would you be open to adding a commit to the PR to resolve this issue? |
Without this change, running "superflore-gen-nix --pr-only" fails with
this error:
!!!! Failed to file PR!
!!!! reason: Cmd('/nix/store/cjw8ydwnifad0wdlkhpsyrdm18bcmg63-git-minimal-2.47.2/bin/git') failed due to: exit code(128)
cmdline: /nix/store/cjw8ydwnifad0wdlkhpsyrdm18bcmg63-git-minimal-2.47.2/bin/git clone -v --branch=master -- https://github.com/./False False
stderr: 'Cloning into 'False'...
remote: Not Found
fatal: repository 'https://github.com/./False/' not found
'
Signed-off-by: Michal Sojka <michal.sojka@cvut.cz>
Signed-off-by: Michal Sojka <michal.sojka@cvut.cz>
wentasah
force-pushed
the
nixos-support
branch
from
136120d to
0b67677
Compare
Contributor
Author
|
I've fixed it in the original commit. Thanks. |
robwoolley
approved these changes
Oct 1, 2025
Contributor
robwoolley
left a comment
robwoolley
left a comment
There was a problem hiding this comment.
Changes appear correct. The same changes were accepted upstream by the NixOS author. Automated CI tests pass.
Also @wentasah confirmed to have validated the changes on his Nix Hydra instance (https://hydra.iid.ciirc.cvut.cz/project/nix-ros-overlay)
Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @robwoolley and others!
I noticed just today that NixOS support has been merged (#309). Thanks for the effort.
For quite some time, we also use two other changes, which are needed for our use case and which I'm submitting here.
These were already merged to the original fork with NixOS support and are used in our Nix ROS overlay.
If this is merged here, we could switch to using upstream superflore version. I've just verified that it works and removes the
pkg_resourceswarning (#315) :-)If you need anything related to Nix support in the future, feel free to ping me.