Allow Users to Tab Through Hues #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Change the click event handler to focus event handler and add a tab index to the hue divs to allow a user to tab through the hues. -Get focus back on the selected hue after the user selects a colour or uses the context menu so that when the user presses tab again it will move to the hue after the selected one.
Owner
|
Hey there! Thanks for the PR. I'm a little hesitant on this because I'm actually hoping longer-term that the entire window isn't focusable (there's a FR w/ the electron project for that). Another solution for switching hues is a set of global hot keys, that I think is worth exploring soon. |
Author
|
If I understand correctly, it would using globalShortcut (https://github.com/electron/electron/blob/master/docs/api/global-shortcut.md) to listen for the tab key or do you have a different key combination in mind? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Change the click event handler to focus event handler and add a tab index to the hue divs to allow a user to tab through the hues.
-Get focus back on the selected hue after the user selects a colour or uses the context menu so that when the user presses tab again it will move to the hue after the selected one.