Enable arrow up/down keys to navigate sidebar#27
Closed
raphaelschaad wants to merge 1 commit intoromannurik:masterfrom
Closed
Enable arrow up/down keys to navigate sidebar#27raphaelschaad wants to merge 1 commit intoromannurik:masterfrom
raphaelschaad wants to merge 1 commit intoromannurik:masterfrom
Conversation
Owner
|
Thanks! One minor bug, when the search field is focused, pressing Up or Down shouldn't switch colors. You may be able to do something along these lines: |
ewanshah
approved these changes
Jan 15, 2017
Owner
|
Dup of #25 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems useful for navigation, and feels nice on hold-keydown to quickly navigate the list up and down.
Should still make sense even if the app becomes a menubar app in the popover style.