Skip to content

Enable arrow up/down keys to navigate sidebar#27

Closed
raphaelschaad wants to merge 1 commit intoromannurik:masterfrom
raphaelschaad:arrow-key-selection
Closed

Enable arrow up/down keys to navigate sidebar#27
raphaelschaad wants to merge 1 commit intoromannurik:masterfrom
raphaelschaad:arrow-key-selection

Conversation

@raphaelschaad
Copy link

Seems useful for navigation, and feels nice on hold-keydown to quickly navigate the list up and down.

Should still make sense even if the app becomes a menubar app in the popover style.

@romannurik
Copy link
Owner

Thanks! One minor bug, when the search field is focused, pressing Up or Down shouldn't switch colors. You may be able to do something along these lines:

  if (document.activeElement.matches('input')) {
    return true;
  }

@romannurik
Copy link
Owner

Dup of #25

@romannurik romannurik closed this Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants