Update controller.py #14
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes modifications to the
src/elliptec/controller.pyfile to improve how theportparameter is handled and simplifies the code by removing unused methods. The most important changes include storing theportparameter as an instance variable, updating the logic in the__search_and_connectmethod to use the storedport, and removing the__enter__and__exit__methods.Improvements to
porthandling:src/elliptec/controller.py: Theportparameter is now stored as an instance variable in the__init__method, enabling better access and management of the port throughout the class.src/elliptec/controller.py: Updated the__search_and_connectmethod to assign theportto the instance variable before passing it to the__connect_to_portmethod. This ensures consistent handling of theport.Code simplification:
src/elliptec/controller.py: Removed the__enter__and__exit__methods, as they were unused and unnecessary for the current functionality of the class.