Skip to content

Feat: pull images before restart #920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0xfornax merged 1 commit into from
Sep 9, 2025
Merged

Feat: pull images before restart #920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions rocketpool-cli/service/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,6 +306,13 @@ func configureService(c *cli.Context) error {
return nil
}

// Let's reduce potential downtime by pulling the new containers before restarting
fmt.Println("Pulling potential new container images...")
err = rp.PullComposeImages(getComposeFiles(c))
if err != nil {
fmt.Fprintf(os.Stderr, "Warning: couldn't pull new images for updated containers: %s\n", err.Error())
}

fmt.Println()
for _, container := range md.ContainersToRestart {
fullName := fmt.Sprintf("%s_%s", prefix, container)
Expand Down
12 changes: 12 additions & 0 deletions shared/services/rocketpool/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -723,6 +723,18 @@ func (c *Client) GetComposeImages(composeFiles []string) ([]string, error) {
return strings.Fields(string(output)), nil
}

func (c *Client) PullComposeImages(composeFiles []string) error {
cmd, err := c.compose(composeFiles, "pull -q")
if err != nil {
return err
}
err = c.printOutput(cmd)
if err != nil {
return fmt.Errorf("error pulling images: %w", err)
}
return nil
}

type DockerImage struct {
Repository string `json:"Repository"`
Tag string `json:"Tag"`
Expand Down
Loading