Skip to content

Conversation

@benv666
Copy link
Contributor

@benv666 benv666 commented Sep 9, 2025

This PR is the same as nodeset-org/hyperdrive#220 but adjusted for the rpl smartnode cli:

Description

This PR is a small optimization that will pull the new docker container images before stopping the currently running ones, resulting in less downtime than before.

Motivation

I've been bitten by having to wait for several containers to be pulled before, which are not only causing unnecessary downtime, but can be especially painful if one gets rate-limited by dockerhub, or when there are other failure modes in the image pull scenario. (e.g. docker disk full - which is not necessarily the same as where the data volumes live)

With this change the containers won't be stopped until the new images are available, potentially preventing these issues and improving uptime.

Changes

Old situation:

  • User updates/manually updates container image to different version
  • rpl asks user to restart
  • user confirms, rpl stops to be restarted containers
  • rpl runs compose up, causing it to start pulling containers
  • containers start

New situation:

  • User updates/manually updates container image to different version
  • rpl asks user to restart
  • user confirms, rpl runs compose pull, causing it to pull new required container images
  • rpl stops to be restarted containers
  • rpl runs compose up
  • containers start

Screenshots

Before - containers are stopped, then new ones pulled, then started
rpl-before

After - new images pulled first, then containers stopped, then started
rpl-pulling-first

@0xfornax 0xfornax merged commit bb152ac into rocket-pool:master Sep 9, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants