Remove Receive 'Msg' type, add actor trait bound#100
Open
mkj wants to merge 1 commit intoriker-rs:masterfrom
Open
Remove Receive 'Msg' type, add actor trait bound#100mkj wants to merge 1 commit intoriker-rs:masterfrom
mkj wants to merge 1 commit intoriker-rs:masterfrom
Conversation
Contributor
|
Hi @mkj I do think you're correct - |
Contributor
|
@leenozara what is the current status on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Msgassociated type ofReceivetrait isn't needed if we require that it's anActor. It reduces a fair bit of boilerplate. The downside I see is that this forcesReceiveto be anActor, though is that a problem?This is more of a query than a solid pull request, but it's easier to show code examples here than an issue. There might be reasons why it won't work, of course it breaks compatibility too.