Skip to content

Consume new CCK Nuget package for Formatter tests; Upgraded dependencies to latest releases of Cucumber assets#984

Open
clrudolphi wants to merge 16 commits intomainfrom
update_Cucumber_Dependencies_01_2026
Open

Consume new CCK Nuget package for Formatter tests; Upgraded dependencies to latest releases of Cucumber assets#984
clrudolphi wants to merge 16 commits intomainfrom
update_Cucumber_Dependencies_01_2026

Conversation

@clrudolphi
Copy link
Contributor

@clrudolphi clrudolphi commented Jan 3, 2026

🤔 What's changed?

Gherkin 38.0.0, Messages 32.0.1 and HtmlFormatter 23.0.0.
This supports the addition of the Location property to Pickles.

Updated Formatters.Tests to use the v29.1.4 release of the CCK (Cucumber Compatibility Kit) scenarios and samples. This now involves consuming a new nuget package from Cucumber (Cucumber/CCK), which automatically positions the CCK samples into the Formatters Test project.

⚡️ What's your motivation?

Keeping up-to-date with Cucumber dependencies and aligned with the CCK.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

📋 Checklist:

  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "[vNext]" section of the CHANGELOG, linking to this pull request & included my GitHub handle to the release contributors list.

This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.

…Messages 31.1.0 and HtmlFormatter 22.3.0. This supports the addition of the Location property to Pickles.

Updated Formatters.Tests to use the latest release of the CCK scenarios and samples.
@clrudolphi clrudolphi added the dependencies Pull requests that update a dependency file label Jan 3, 2026
@clrudolphi clrudolphi requested a review from gasparnagy January 4, 2026 16:22
Copy link
Contributor

@gasparnagy gasparnagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine/thx.
Let's wait with the me merge, because this must go to v3.4 or v4.0 (whichever comes earlier)

@gasparnagy gasparnagy added this to the v3.4 milestone Jan 6, 2026
Adjusted test .csproj to embed the CCK assets in test output assembly.
Fixed Formatters to conform to Messages expectation that Pending steps have no error message text.
Moved the 'all-statuses' scenario to NonCompliant until ambiguous step match arguments can be surfaced.
@clrudolphi clrudolphi changed the title Upgraded dependencies to latest releases of Cucumber assets Consume new CCK Nuget package for Formatter tests; Upgraded dependencies to latest releases of Cucumber assets Feb 24, 2026
@clrudolphi clrudolphi self-assigned this Feb 24, 2026
@clrudolphi
Copy link
Contributor Author

clrudolphi commented Feb 24, 2026

Sorry to leave this in a broken state. I'll fix it tomorrow.

I do have more work to do on this around the way we surface arguments to matched step bindings:

  • - Ambiguous step binding situations are supposed to include the matched arguments for each (right now Reqnroll does not) {Fixed. This was an error within the tests on my part.}
  • - Arguments are supposed to be surfaced as a tree representing the nested capture groups of the regexes that generated the match (we only have the leaf nodes). {See separate issue created: Formatters: StepArgumentTransformations not completely compliant with CCK #1048 }

@clrudolphi clrudolphi marked this pull request as draft February 24, 2026 23:23
@304NotModified
Copy link
Member

What is CCK? CuCumber K..?

@clrudolphi
Copy link
Contributor Author

What is CCK? CuCumber K..?

CCK = Cucumber Compatibility Kit. (https://github.com/cucumber/compatibility-kit)

It provides a set of normative examples of features and bindings and the ndjson that any compatible Cucumber implementation should produce as a result. I've been using it in the Reqnroll.Formatters.Tests suite to show compliance with the Messages standard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants