PROTOTYPE: Formatters external attachments aligned with test framework#1056
Draft
clrudolphi wants to merge 19 commits intomainfrom
Draft
PROTOTYPE: Formatters external attachments aligned with test framework#1056clrudolphi wants to merge 19 commits intomainfrom
clrudolphi wants to merge 19 commits intomainfrom
Conversation
…Messages 31.1.0 and HtmlFormatter 22.3.0. This supports the addition of the Location property to Pickles. Updated Formatters.Tests to use the latest release of the CCK scenarios and samples.
…atuses scenario and other minor restructuring)
Adjusted test .csproj to embed the CCK assets in test output assembly.
Fixed Formatters to conform to Messages expectation that Pending steps have no error message text. Moved the 'all-statuses' scenario to NonCompliant until ambiguous step match arguments can be surfaced.
…ing the CCK resources.
…ither link to external attachments in its reports or embed file contents. This prototype aligns with that behavior so that Formatter handling of attachments is driven according to which test framework is being used.
clrudolphi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
NOTE: Not ready for merge. This PR is branched from PR #984.
NOTE: This PR provides an alternate implementation to the prototype in PR #1015.
⚡️ What's your motivation?
Each test framework either supports including a link to a test attachment in its test results or will embed the contents of the attachment within the report. In this PR, Formatters aligns with that behavior. If the test framework links, then Formatters will link via an
ExternalAttachmentmessage; or if the test framework embeds content, then the Formatters will embed via anAttachmentmessage.A public property is added to
IUnitTestRunTimeProvidersuch that each plug-in can indicate what style of attachment handling should be used.The overall implementation is simpler than the other prototype as we have no configuration to resolve and behavior is not specific to any given formatter.
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
📋 Checklist:
This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.