rescue from Seahorse::Client::NetworkingError
#39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
When you fix some errors, can you give us more information such as a stack trace like below? Such information helps us a lot to know the background of PRs and review changes. |
abicky
reviewed
Jan 28, 2021
| end | ||
|
|
||
| @cv.broadcast | ||
| rescue Seahorse::Client::NetworkingError => e |
Contributor
There was a problem hiding this comment.
I think the following code is simpler and better:
rescue Aws::ECS::Errors::ThrottlingException, Seahorse::Client::NetworkingError => e
Wrapbox.logger.warn("Failed to describe tasks: #{e} (#{e.class})")
endWhat do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occurred error
Seahorse::Client::NetworkingErrorat wrapbox initializing.I add rescue from this error.