Skip to content

XMLDictionary import fixed#36

Open
dpyro wants to merge 1 commit intorenebigot:masterfrom
dpyro:xmldictionary-import-fix
Open

XMLDictionary import fixed#36
dpyro wants to merge 1 commit intorenebigot:masterfrom
dpyro:xmldictionary-import-fix

Conversation

@dpyro
Copy link

@dpyro dpyro commented May 30, 2016

XMLDictionary import needs to be converted to angle bracket form to work with CocoaPods, as a subproject, etc on the first go.

To work with cocoapods, as subproject, etc.
@sohayb
Copy link

sohayb commented Jul 10, 2016

@renebigot can you please merge this pull request!

@renebigot
Copy link
Owner

Hi @sohayb,
I'm testing it. I can't compile with brackets. Only with quotes. I'm searching why.

@sohayb
Copy link

sohayb commented Jul 10, 2016

That's weird! Because I'm using this commit's branch as a pod dependency and it's working.

@mheicke
Copy link

mheicke commented Aug 12, 2016

I would be highly interested in getting this fixed. @sohayb : have you tried to use quotes instead of brackets? It's working for me and so renebigot could merge

@sohayb
Copy link

sohayb commented Aug 12, 2016

I tested with "XMLDictionary/XMLDictionary.h" rather than <XMLDictionary/XMLDictionary.h> and it all works. Don't know why the latter didn't work tho. Never the less, since the quotes are working, @renebigot can you please merge that into master and publish/update pod so we can live happily ever after? 😊
cc @mheicke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants