Skip to content

fixed broken XMLDictionary.h import#44

Open
mheicke wants to merge 1 commit intorenebigot:masterfrom
mheicke:master
Open

fixed broken XMLDictionary.h import#44
mheicke wants to merge 1 commit intorenebigot:masterfrom
mheicke:master

Conversation

@mheicke
Copy link

@mheicke mheicke commented Aug 12, 2016

fix for broken PR: #36

@mheicke
Copy link
Author

mheicke commented Aug 12, 2016

not sure who quick how quick @dphov will respond, so I just fixed it by myself (since it's only a couple of changed imports)

@DannyEspina
Copy link

Hey this might be super late but I found an alternate solution to this problem. Adding XMLDictionary/XMLDictionary.h causes an Include of non-modular header inside framework module error when you archive the project.

I solve this by adding XMLDictionary.h to the public headers of XlsxReaderWriter in Build Phases and leaving import "XMLDictionary.h" alone. This solves this issue and the non-modular header issue.

I hope this helps someone.

my question with my answer on stack overflow: https://stackoverflow.com/a/59492076/3749869

@charlymr
Copy link

I fork the repo and support Framework, and much mor if you are interested. FYI. XMLDictionary has been abandoned, so I removed the dependency and integrated it directly in the project.

https://github.com/charlymr/XlsxReaderWriter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants