Skip to content

[PHPUnit 12] Skip First class callable on DirectInstanceOverMockArgRector #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samsonasik merged 2 commits into from
Jan 26, 2026
Merged

[PHPUnit 12] Skip First class callable on DirectInstanceOverMockArgRector #610

samsonasik merged 2 commits into from
Jan 26, 2026

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented Jan 26, 2026

Avoid error:

There was 1 failure:

1) Rector\PHPUnit\Tests\CodeQuality\Rector\CallLike\DirectInstanceOverMockArgRector\DirectInstanceOverMockArgRectorTest::test with data set #3 ('/Users/samsonasik/www/rector-...hp.inc')
assert(!$this->isFirstClassCallable())

/Users/samsonasik/www/rector-phpunit/vendor/nikic/php-parser/lib/PhpParser/Node/Expr/CallLike.php:32
/Users/samsonasik/www/rector-phpunit/rules/CodeQuality/Rector/CallLike/DirectInstanceOverMockArgRector.php:108

Ref #609 (review)

@samsonasik samsonasik mentioned this pull request Jan 26, 2026
Merged
@samsonasik
Copy link
Member Author

samsonasik commented Jan 26, 2026

Fixed 🎉 /cc @TomasVotruba

@samsonasik
Copy link
Member Author

samsonasik commented Jan 26, 2026

@TomasVotruba ready 👍I am merging it ;)

@samsonasik samsonasik merged commit f9c08fa into main Jan 26, 2026
7 checks passed
@samsonasik samsonasik deleted the skip-first branch January 26, 2026 12:49
TomasVotruba
TomasVotruba reviewed Jan 26, 2026
View reviewed changes
rules/CodeQuality/Rector/CallLike/DirectInstanceOverMockArgRector.php
return null;
}

if ($methodCall->isFirstClassCallable()) {
Copy link
Member

@TomasVotruba TomasVotruba Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already handled here.

Copy link
Member Author

@samsonasik samsonasik Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, different position, parent method call, and arg as method call , see error

https://github.com/rectorphp/rector-phpunit/actions/runs/21358188769/job/61470545174

Copy link
Member

@TomasVotruba TomasVotruba Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, that's different call. Ok 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomasVotruba TomasVotruba TomasVotruba left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@samsonasik @TomasVotruba