[code-quality] Add DirectInstanceOverMockArgRector #609
+365
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
force-pushed
the
tv-direct-object-over-mock
branch
from
269c761 to
c437551
Compare
TomasVotruba
force-pushed
the
tv-direct-object-over-mock
branch
from
c437551 to
680912f
Compare
samsonasik
reviewed
Jan 26, 2026
| return $this->refactorArrayItem($node); | ||
| } | ||
|
|
||
| foreach ($node->getArgs() as $arg) { |
Member
There was a problem hiding this comment.
->isFirstClassCallable() should be checked early before ->getArgs()
Member
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on PHPUnit 12, I've noticed some classes are mocked, but only passed allong as objects.
It doesn't bring any value, esp. for simple objects like
RequestandRequestStackuse PHPUnit\Framework\TestCase; use Symfony\Component\HttpFoundation\Request; final class SomeTest extends TestCase { public function test() { - $this->someMethod($this->createMock(Request::class)); + $this->someMethod(new Request()); } private function someMethod($someClass) { } }