Skip to content

Make the tests for the summary text more accepting of line breaks. #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yeojunjie wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make the tests for the summary text more accepting of line breaks. #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7a7ed0
Fix test for summary display
yeojunjie Feb 28, 2024
6280e2a
FIx two tests for summary display
yeojunjie Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/__tests__/pokemon-list.test.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ describe("Pokemon list with 'Load more' button", () => {
// Check that the summary correctly says how many items are shown
expect(
await screen.findByText(
`Displaying 5 of ${pokemonsResultPage1.count} results`
new RegExp(`Displaying 5 of ${pokemonsResultPage1.count} results`, 's')
)
).toBeInTheDocument();
});
Expand All @@ -89,7 +89,7 @@ describe("Pokemon list with 'Load more' button", () => {
// Check that the summary correctly updated
expect(
await screen.findByText(
`Displaying 10 of ${pokemonsResultPage1.count} results`
new RegExp(`Displaying 10 of ${pokemonsResultPage1.count} results`, 's')
)
).toBeInTheDocument();

Expand Down Expand Up @@ -125,7 +125,7 @@ describe("Pokemon list with 'Load more' button", () => {

// Check that the summary correctly updated
expect(
await screen.findByText("Displaying 12 of 12 results")
await screen.findByText(/Displaying 12 of 12 results/)
).toBeInTheDocument();

// Check that 12 items are displayed
Expand Down