Make the tests for the summary text more accepting of line breaks.#2
Open
yeojunjie wants to merge 2 commits intoreactpractice-dev:mainfrom
Open
Make the tests for the summary text more accepting of line breaks.#2yeojunjie wants to merge 2 commits intoreactpractice-dev:mainfrom
yeojunjie wants to merge 2 commits intoreactpractice-dev:mainfrom
Conversation
|
Thank you for your contribution! Are you sure it's the line breaks that cause the tests to fail? The official solution also shows the summary wrapped in If you will share your solution, I'd be happy to take a look to see what else might be the issue! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solutions which include
will show up as
which is not detected by
.findByTextas it currently is.This modification makes the tests for the summary text more accepting of line breaks caused by using
{}within<p></p>.