Skip to content

gh26 - no release push in cli #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BenjiMilan merged 1 commit into from
Feb 9, 2026
Merged

gh26 - no release push in cli #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/sc/branching_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,11 @@ def pull():
"""Pull down the latest changes from the remote branch."""
SCBranching.pull(BranchType.RELEASE)

@release.command()
@click.argument('name', required=False)
def push(name: str):
"""Push release branch to remote, if a repo project updates the manifest with the lastest commits."""
Copy link

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in docstring: "lastest" should be "latest".

Suggested change
"""Push release branch to remote, if a repo project updates the manifest with the lastest commits."""
"""Push release branch to remote, if a repo project updates the manifest with the latest commits."""

Copilot uses AI. Check for mistakes.
SCBranching.push(BranchType.RELEASE, name)
Comment on lines +194 to +197
Copy link

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name is declared as an optional Click argument (required=False), so it may be None. The type annotation should reflect that (e.g., str | None) to avoid misleading type checkers/readers.

Copilot uses AI. Check for mistakes.

@release.command()
@click.argument('name')
Expand Down
Loading