gh26 - no release push in cli #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
Adds the missing sc release push subcommand so users can push release branches to the remote (including repo/manifest updates), addressing Issue #26.
Changes:
- Introduces a new
release pushCLI command wired toSCBranching.push(BranchType.RELEASE, name).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+194
to
+197
| @click.argument('name', required=False) | ||
| def push(name: str): | ||
| """Push release branch to remote, if a repo project updates the manifest with the lastest commits.""" | ||
| SCBranching.push(BranchType.RELEASE, name) |
There was a problem hiding this comment.
name is declared as an optional Click argument (required=False), so it may be None. The type annotation should reflect that (e.g., str | None) to avoid misleading type checkers/readers.
| @release.command() | ||
| @click.argument('name', required=False) | ||
| def push(name: str): | ||
| """Push release branch to remote, if a repo project updates the manifest with the lastest commits.""" |
There was a problem hiding this comment.
Typo in docstring: "lastest" should be "latest".
Suggested change
| """Push release branch to remote, if a repo project updates the manifest with the lastest commits.""" | |
| """Push release branch to remote, if a repo project updates the manifest with the latest commits.""" |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add release push to cli.
Closes #26