Dynamic properties #1065
Closed
Dynamic properties #1065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
React\Socket\Connection::$decor Ratchet\Server\IoConnection::$resourceId Ratchet\Server\IoConnection::$remoteAddress Ratchet\Server\IoConnection::$httpHeadersReceived Ratchet\Server\IoConnection::$httpBuffer Ratchet\Server\IoConnection::$httpRequest Ratchet\Server\IoConnection::$WebSocket
React\Socket\Connection::$decor Ratchet\Server\IoConnection::$resourceId Ratchet\Server\IoConnection::$remoteAddress Ratchet\Server\IoConnection::$httpHeadersReceived Ratchet\Server\IoConnection::$httpBuffer Ratchet\Server\IoConnection::$httpRequest Ratchet\Server\IoConnection::$WebSocket
React\Socket\Connection::$decor
React\Socket\Connection::$decor
|
Maybe a proper fix should be both #1060 and this, because it was previously encouraged to add properties to the connection in |
marinhekman
added a commit
to BredaUniversityResearch/Ratchet
that referenced
this pull request
Feb 6, 2025
marinhekman
added a commit
to BredaUniversityResearch/Ratchet
that referenced
this pull request
Feb 7, 2025
This reverts commit 062d386.
Contributor
|
Hey! Thanks for this pull request 🙏 As part of our cleanup initiative (#1100), we're closing old PRs that have already been resolved. We've recently merged #1096 which implements the same idea, but turned out to be a bit more involved than initially anticipated. If you have further improvements to suggest, feel free to open a new pull request. We appreciate your contributions and welcome any future enhancements. If you want to support Ratchet, please consider sponsoring our work! ❤️ Thanks again for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP Compatability for Dynamic Properties
React\Socket\Connection::$decor
Ratchet\Server\IoConnection::$resourceId
Ratchet\Server\IoConnection::$remoteAddress
Ratchet\Server\IoConnection::$httpHeadersReceived
Ratchet\Server\IoConnection::$httpBuffer
Ratchet\Server\IoConnection::$httpRequest
Ratchet\Server\IoConnection::$WebSocket