Skip to content

Conversation

@JohnRDOrazio
Copy link

fix dynamic properties warnings for PHP >= 8.2

fix dynamic properties warnings for PHP >= 8.2
@JohnRDOrazio
Copy link
Author

this is a simple and straightforward way to fix issue #1003 , without having to explicitly declare all of the properties for every class.

Copy link

@VidarSandvik VidarSandvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it fixed some issues but basically the entire ratchet needs to be updated to support above PHP 8.2

@Qosimjondev
Copy link

Need connection class change

@JohnRDOrazio
Copy link
Author

JohnRDOrazio commented Jun 26, 2024

Need connection class change

I assume you mean that we need the same fix on React\Socket\Connection. This however is in a different repository (https://github.com/reactphp/socket/). Perhaps it would be fixed by PR #1065?

@PaulRotmann
Copy link
Contributor

PaulRotmann commented May 30, 2025

Hey! Thanks for this pull request 🙏

As part of our cleanup initiative (#1100), we're closing old PRs that have already been resolved. We've recently merged #1096 which implements the same idea, but turned out to be a bit more involved than initially anticipated.

If you have further improvements to suggest, feel free to open a new pull request. We appreciate your contributions and welcome any future enhancements. If you want to support Ratchet, please consider sponsoring our work! ❤️

Thanks again for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants