Removal of bicep-types submodule with migration to pnpm#11139
Open
brooke-hamilton wants to merge 29 commits intoradius-project:mainfrom
Open
Removal of bicep-types submodule with migration to pnpm#11139brooke-hamilton wants to merge 29 commits intoradius-project:mainfrom
brooke-hamilton wants to merge 29 commits intoradius-project:mainfrom
Conversation
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the bicep-types git submodule and migrates the repo’s JS/TS dependency management (notably typespec/ and hack/bicep-types-radius/) from npm to pnpm, updating workflows, devcontainer setup, and developer docs accordingly.
Changes:
- Removed
bicep-typessubmodule wiring (bicep-types,.gitmodules) and submodule-related build checks. - Added pnpm lockfiles and updated build/generation scripts to use pnpm.
- Updated GitHub workflows, devcontainer bootstrap, and contributor docs (including a migration guide).
Reviewed changes
Copilot reviewed 23 out of 29 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| typespec/pnpm-lock.yaml | Adds pnpm lockfile for TypeSpec tooling. |
| typespec/package-lock.json | Removes npm lockfile in favor of pnpm. |
| hack/bicep-types-radius/src/generator/pnpm-lock.yaml | Adds pnpm lockfile for the generator package. |
| hack/bicep-types-radius/src/generator/package.json | Switches bicep-types source to a git dependency and adds postinstall build/link logic. |
| hack/bicep-types-radius/src/generator/.npmrc | Configures pnpm behavior for the generator package. |
| hack/bicep-types-radius/src/autorest.bicep/package.json | Switches bicep-types source to a git dependency and adds postinstall build/link logic. |
| hack/bicep-types-radius/src/autorest.bicep/.npmrc | Configures pnpm behavior for the autorest extension package. |
| docs/contributing/contributing-code/contributing-code-prerequisites/README.md | Updates codegen prerequisites from npm to pnpm commands. |
| docs/contributing/contributing-code/contributing-code-building/README.md | Removes submodule-related build note. |
| docs/contributing/bicep-types-migration-guide.md | Adds migration steps for existing clones. |
| build/test.mk | Updates oav installation guidance to pnpm. |
| build/generate.mk | Updates generator prerequisites and bicep-types generation flow to pnpm. |
| build/build.mk | Removes submodule existence/version checks from make build. |
| bicep-types | Removes the submodule entry. |
| .gitmodules | Removes submodule configuration. |
| .github/workflows/validate-bicep.yaml | Removes submodule checkout and adds pnpm setup. |
| .github/workflows/publish-docs.yaml | Removes submodule checkout and migrates TypeSpec/autorest/oav installs to pnpm. |
| .github/workflows/long-running-azure.yaml | Removes submodule checkout. |
| .github/workflows/lint.yaml | Removes submodule checkout and migrates TypeSpec/autorest/oav installs to pnpm. |
| .github/workflows/functional-test-noncloud.yaml | Removes submodule checkout and adds pnpm setup. |
| .github/workflows/functional-test-cloud.yaml | Removes submodule checkout. |
| .github/workflows/codeql.yml | Removes submodule checkout and adds pnpm setup for JS analysis. |
| .github/workflows/build.yaml | Removes submodule checkout and adds pnpm setup before bicep-types generation. |
| .github/dependabot.yml | Replaces submodule updates with npm-ecosystem updates for the pnpm-managed projects. |
| .devcontainer/post-create.sh | Migrates devcontainer bootstrap steps to pnpm and adds pnpm configuration. |
| .devcontainer/devcontainer.json | Configures devcontainer Node feature to install pnpm v10. |
Files not reviewed (4)
- hack/bicep-types-radius/src/generator/package-lock.json: Language not supported
- hack/bicep-types-radius/src/generator/pnpm-lock.yaml: Language not supported
- typespec/package-lock.json: Language not supported
- typespec/pnpm-lock.yaml: Language not supported
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
DariuszPorowski
previously approved these changes
Feb 2, 2026
Member
DariuszPorowski
left a comment
There was a problem hiding this comment.
LGTM, just one suggestion for dev container
Co-authored-by: Dariusz Porowski <3431813+DariuszPorowski@users.noreply.github.com> Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
12 tasks
sylvainsf
added a commit
that referenced
this pull request
Feb 4, 2026
# Description Fixes a bug introduced in PR #11169 where org members (like PR #11139 from @brooke-hamilton) were incorrectly being blocked by the approval gate. The `&&` operator has higher precedence than `||` in GitHub expressions. Without parentheses, the expression was incorrectly evaluating to `'external-contributor-approval'` for ALL PRs, blocking org members. Added parentheses to group the trusted user check so it correctly returns empty string (no approval needed) for dependabot and org members. ## Type of change - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional). ## Contributor checklist Please verify that the PR meets the following requirements, where applicable: - An overview of proposed schema changes is included in a linked GitHub issue. - [ ] Yes - [x] Not applicable - A design document PR is created in the [design-notes repository](https://github.com/radius-project/design-notes/), if new APIs are being introduced. - [ ] Yes - [x] Not applicable - The design document has been reviewed and approved by Radius maintainers/approvers. - [ ] Yes - [x] Not applicable - A PR for the [samples repository](https://github.com/radius-project/samples) is created, if existing samples are affected by the changes in this PR. - [ ] Yes - [x] Not applicable - A PR for the [documentation repository](https://github.com/radius-project/docs) is created, if the changes in this PR affect the documentation or any user facing updates are made. - [ ] Yes - [x] Not applicable - A PR for the [recipes repository](https://github.com/radius-project/recipes) is created, if existing recipes are affected by the changes in this PR. - [ ] Yes - [x] Not applicable
12 tasks
Copilot AI
added a commit
that referenced
this pull request
Feb 5, 2026
This adds pnpm installation steps to workflows that need it: - build.yaml (generate-bicep-types job) - lint.yaml - functional-test-noncloud.yaml - codeql.yml (for JavaScript analysis) - publish-docs.yaml - validate-bicep.yaml This is a prerequisite for PR #11139 which migrates the codebase to use pnpm. Co-authored-by: brooke-hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Radius functional test overviewClick here to see the test run details
Test Status⌛ Building Radius and pushing container images for functional tests... |
…ep-types-submodule-1
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the
bicep-typesgit submodule and migrates JavaScript/TypeScript package management from npm to pnpm. Thebicep-typesdependency is now fetched as a git dependency and built via apostinstallscript, simplifying the developer experience.Key changes:
bicep-typesgit submodule and.gitmodulesfilepackage-lock.json) to pnpm (pnpm-lock.yaml) for:typespec/hack/bicep-types-radius/src/generator/hack/bicep-types-radius/src/autorest.bicep/package.jsonto ensure dev dependencies are at consistent versions and updated with dependabot.Type of change
Testing
docs/contributing/bicep-types-migration-guide.md.Contributor checklist
Please verify that the PR meets the following requirements, where applicable:
Related PRs: