Fix operator precedence in approval-gate environment expression#11170
Merged
Fix operator precedence in approval-gate environment expression#11170
Conversation
The && operator has higher precedence than || in GitHub expressions. Without parentheses, the expression was incorrectly evaluating to 'external-contributor-approval' for ALL PRs, blocking org members. Fixed by adding parentheses around the trusted user check so it correctly returns '' (empty/no environment) for dependabot and org members (OWNER, MEMBER, COLLABORATOR). Before (buggy): actor == 'dependabot[bot]' || contains(...) && '' || 'external-...' After (fixed): (actor == 'dependabot[bot]' || contains(...)) && '' || 'external-...'
sylvainsf
requested a deployment
to
external-contributor-approval
GitHub Actions
Waiting
sylvainsf
temporarily deployed
to
publish-bicep
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug introduced in PR #11169 where org members (like PR #11139 from @brooke-hamilton) were incorrectly being blocked by the approval gate.
The
&&operator has higher precedence than||in GitHub expressions. Without parentheses, the expression was incorrectly evaluating to'external-contributor-approval'for ALL PRs, blocking org members.Added parentheses to group the trusted user check so it correctly returns empty string (no approval needed) for dependabot and org members.
Type of change
Contributor checklist
Please verify that the PR meets the following requirements, where applicable: