Skip to content

switch to cibuildwheel for pypi compatability #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deronsmith merged 1 commit into from
Jun 23, 2025
Merged

switch to cibuildwheel for pypi compatability #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 15 additions & 50 deletions .github/workflows/package-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,14 @@ jobs:
echo "PATH=${PATH}:${HOME}/.cargo/bin" >> "$GITHUB_ENV"
rustc --version
python -m pip install build setuptools setuptools-rust
- name: Build wheels
run:
python -m build --outdir py_dist
- name: Build wheels with cibuildwheel
run: |
python -m pip install --upgrade pip
python -m pip install cibuildwheel==2.22.0
python -m cibuildwheel --output-dir py_dist
# - name: Build wheels
# run:
# python -m build --outdir py_dist
Comment on lines +40 to +42
Copy link

Copilot AI Jun 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider removing the commented-out legacy build steps if they are no longer needed to keep the workflow file clean.

Suggested change
# - name: Build wheels
# run:
# python -m build --outdir py_dist
# (Removed commented-out legacy build steps)

Copilot uses AI. Check for mistakes.
- name: Store the compiled packages
uses: actions/upload-artifact@v4
with:
Expand All @@ -58,8 +63,13 @@ jobs:
curl https://sh.rustup.rs -sSf | sh -s -- -y --default-toolchain=stable
echo "${HOME}/.cargo/bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
python -m pip install build setuptools setuptools-rust
- name: Build wheels
run: python -m build --outdir py_dist
# - name: Build wheels
# run: python -m build --outdir py_dist
Comment on lines +66 to +67
Copy link

Copilot AI Jun 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider removing the old commented build steps from the Windows section if they are no longer relevant to simplify maintenance.

Suggested change
# - name: Build wheels
# run: python -m build --outdir py_dist

Copilot uses AI. Check for mistakes.
- name: Build wheels with cibuildwheel
run: |
python -m pip install --upgrade pip
python -m pip install cibuildwheel==2.22.0
python -m cibuildwheel --output-dir py_dist
- name: Store the compiled packages
uses: actions/upload-artifact@v4
with:
Expand Down Expand Up @@ -144,48 +154,3 @@ jobs:
uses: pypa/gh-action-pypi-publish@release/v1
with:
packages-dir: py_dist/

# Currently not intending on using automated github-release as the primary trigger for pypi publishing is by creating
# a new github version release. This is done manually by the developer.
# github-release:
# name: >-
# Sign the Python 🐍 distribution 📦 with Sigstore
# and upload them to GitHub Release
# needs:
# - publish-to-pypi
# runs-on: ubuntu-latest
#
# permissions:
# contents: write # IMPORTANT: mandatory for making GitHub Releases
# id-token: write # IMPORTANT: mandatory for sigstore
#
# steps:
# - name: Download all the dists
# uses: actions/download-artifact@v4
# with:
# name: python-package-distributions
# path: py_dist/
# - name: Sign the dists with Sigstore
# uses: sigstore/gh-action-sigstore-python@v3.0.0
# with:
# inputs: >-
# ./py_dist/*.tar.gz
# ./py_dist/*.whl
# - name: Create GitHub Release
# env:
# GITHUB_TOKEN: ${{ github.token }}
# run: >-
# gh release create
# '${{ github.ref_name }}'
# --repo '${{ github.repository }}'
# --notes ""
# - name: Upload artifact signatures to GitHub Release
# env:
# GITHUB_TOKEN: ${{ github.token }}
# # Upload to GitHub Release using the `gh` CLI.
# # `dist/` contains the built packages, and the
# # sigstore-produced signatures and certificates.
# run: >-
# gh release upload
# '${{ github.ref_name }}' py_dist/**
# --repo '${{ github.repository }}'