switch to cibuildwheel for pypi compatability#27
Merged
deronsmith merged 1 commit intomainfrom Jun 23, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the package publish workflow to use cibuildwheel for building Python wheels for PyPI compatibility. The changes replace the existing build process with cibuildwheel in two job sections and remove legacy commented-out build steps.
Comment on lines
+40
to
+42
| # - name: Build wheels | ||
| # run: | ||
| # python -m build --outdir py_dist |
There was a problem hiding this comment.
[nitpick] Consider removing the commented-out legacy build steps if they are no longer needed to keep the workflow file clean.
Suggested change
| # - name: Build wheels | |
| # run: | |
| # python -m build --outdir py_dist | |
| # (Removed commented-out legacy build steps) |
Comment on lines
+66
to
+67
| # - name: Build wheels | ||
| # run: python -m build --outdir py_dist |
There was a problem hiding this comment.
[nitpick] Consider removing the old commented build steps from the Windows section if they are no longer relevant to simplify maintenance.
Suggested change
| # - name: Build wheels | |
| # run: python -m build --outdir py_dist |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.