-
Notifications
You must be signed in to change notification settings - Fork 3
LEDS interface I2S setup/async mode #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
SpComb
wants to merge
27
commits into
master
Choose a base branch
from
i2s-out-async
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
54.6 FPS with |
…OUT_TOTAL_EOF_INT
Member
Author
|
This is still recoverable per |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86
New
leds->interface_setup = truemode to replace theleds_tx()->i2s_out_setup()with a one-timei2s_out_setup(). This only works with oneledsper interface, and does not work if sharing interfaces between multipleledsinstances. This is currently only supported for I2S interfaces, and has no effect for other interfaces.This allows a new async mode of operation where
leds_interface_i2s_tx()now callsi2s_out_write_*()->i2s_out_start()instead ofi2s_out_flush(), which fills the I2S DMA buffer and starts the DMA/TX as previously, but does not wait for it to complete. The next loop -> tx can then start filling up the DMA buffer as DMA descriptors are freed up by the EOF interrupt, and waits for the previous TX to complete before starting the new TX using the recycled DMA buffer/descriptors.This significantly increases the efficiency of the LEDS I2S interface, and it can now reach framerates close to the theoretical maximum (
800kbps / (24-bits-per-pixel × pixel-count)).