Skip to content

Better handling of linting/packaging dependencies #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DimitriPapadopoulos wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −3
Open

Better handling of linting/packaging dependencies #680

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c483ce
Better handling of linting/packaging dependencies
DimitriPapadopoulos Feb 27, 2026
33dee00
Dependency groups are supported only from v4.22 onwards
DimitriPapadopoulos Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ wheel = "wheel._commands:main"
bdist_wheel = "wheel.bdist_wheel:bdist_wheel"

[dependency-groups]
lint = ["pre-commit"]
test = [
"packaging >= 26.0",
"pytest >= 6.0.0",
Expand Down Expand Up @@ -121,6 +122,7 @@ mypy-init-return = true

[tool.tox]
env_list = ["py39", "py310", "py311", "py312", "py313", "py314", "pypy3", "lint", "pkg"]
requires = ["tox>=4.22"]
skip_missing_interpreters = true

[tool.tox.env_run_base]
Expand All @@ -131,11 +133,9 @@ dependency_groups = ["test"]
set_env = { PYTHONWARNDEFAULTENCODING = "1" }

[tool.tox.env.lint]
depends = []
deps = ["pre-commit"]
dependency_groups = "lint"
package = "skip"
commands = [["pre-commit", "run", "-a"]]

[tool.tox.env.pkg]
deps = ["build", "flit >= 3.8"]
Copy link
Contributor

@agronholm agronholm Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you actually test this? I did, and it breaks the pkg environment because flit and build are no longer available at run-time.

Copy link
Contributor Author

@DimitriPapadopoulos DimitriPapadopoulos Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have to test again. I thought tox would install the build system automatically. I'll have to investigate how to achieve that.

Is flit required or is flit-core enough?

Copy link
Contributor

@agronholm agronholm Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_compare_sdists explicitly invokes both build and flit.

commands = [["pytest", "tests/test_sdist.py", { replace = "posargs", extend = true }]]
Loading