Better handling of linting/packaging dependencies#680
Open
DimitriPapadopoulos wants to merge 1 commit intopypa:mainfrom
Open
Better handling of linting/packaging dependencies#680DimitriPapadopoulos wants to merge 1 commit intopypa:mainfrom
DimitriPapadopoulos wants to merge 1 commit intopypa:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #680 +/- ##
=======================================
Coverage 55.14% 55.14%
=======================================
Files 15 15
Lines 1206 1206
=======================================
Hits 665 665
Misses 541 541 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DimitriPapadopoulos
force-pushed
the
flit_version
branch
from
4e8b38e to
35e763f
Compare
DimitriPapadopoulos
changed the title
- Basic support for PEP 639 requires flit version 3.11. Specify it in a single place, the [build-system] section - tox should be able to read it from there. - Intoduce a new dependency group for linting, and instruct tox to use it to install linting dependencies. Dependency groups require tox 4.
DimitriPapadopoulos
force-pushed
the
flit_version
branch
from
35e763f to
2c483ce
Compare
agronholm
requested changes
Feb 27, 2026
Contributor
agronholm
left a comment
agronholm
left a comment
There was a problem hiding this comment.
I'm not convinced yet.
|
|
||
| [tool.tox] | ||
| env_list = ["py39", "py310", "py311", "py312", "py313", "py314", "pypy3", "lint", "pkg"] | ||
| requires = ["tox>=4"] |
Contributor
There was a problem hiding this comment.
Dependency groups are supported only from v4.22 onwards.
Suggested change
| requires = ["tox>=4"] | |
| requires = ["tox>=4.22"] |
| [tool.tox.env.lint] | ||
| depends = [] | ||
| deps = ["pre-commit"] | ||
| dependency_groups = "lint" |
Contributor
There was a problem hiding this comment.
What is the point of moving this to a dependency group? I don't see any benefit.
| commands = [["pre-commit", "run", "-a"]] | ||
|
|
||
| [tool.tox.env.pkg] | ||
| deps = ["build", "flit >= 3.8"] |
Contributor
There was a problem hiding this comment.
Did you actually test this? I did, and it breaks the pkg environment because flit and build are no longer available at run-time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic support for PEP 639 requires flit 3.11.
The minimal version is specified in two different places, only the first one had been updated:
wheel/pyproject.toml
Lines 1 to 2 in 56223f6
wheel/pyproject.toml
Lines 139 to 140 in 56223f6
I wonder whether a single occurrence of the minimal version is possible... It appears it should be possible to specify all dependencies in a single place. Modernize dependency handling to achieve that.