Skip to content

Enhance Docker build caching and update documentation #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ptr727 merged 5 commits into from
Feb 5, 2026
Merged

Enhance Docker build caching and update documentation #324

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8b9e309
Develop (#319)
ptr727 Feb 5, 2026
403300a
Fix syntax in jq command for generating docker hub repositories (#320)
ptr727 Feb 5, 2026
eb5eed0
Update cache-to logic in Docker build step for feature branches (#321)
ptr727 Feb 5, 2026
1b7a5c9
Merge remote-tracking branch 'origin/develop'
ptr727 Feb 5, 2026
5e36850
fix: Add cache_tag to base image definitions for improved caching in …
ptr727 Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions .github/workflows/build-base-images-task.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,16 @@ jobs:
strategy:
matrix:
base:
- name: nx-base
dockerfile: Docker/NxBase.Dockerfile
tags: |
docker.io/ptr727/nx-base:ubuntu-noble
- name: nx-base-lsio
dockerfile: Docker/NxBase-LSIO.Dockerfile
tags: |
docker.io/ptr727/nx-base-lsio:ubuntu-noble
- name: nx-base
dockerfile: Docker/NxBase.Dockerfile
cache_tag: docker.io/ptr727/nx-base:ubuntu-noble
tags: |
docker.io/ptr727/nx-base:ubuntu-noble
- name: nx-base-lsio
dockerfile: Docker/NxBase-LSIO.Dockerfile
cache_tag: docker.io/ptr727/nx-base-lsio:ubuntu-noble
tags: |
docker.io/ptr727/nx-base-lsio:ubuntu-noble
Comment on lines +20 to +29
Copy link

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description mentions "Update the Docker Hub README and GitHub Copilot guidance for better clarity and usability" and "Fix syntax issues in the jq command for generating Docker Hub repositories", but these changes are not present in the diff. Either these changes were not included in this PR, or the PR description is inaccurate. Please ensure the PR description accurately reflects the actual changes included.

Copilot uses AI. Check for mistakes.

steps:

Expand Down Expand Up @@ -55,9 +57,9 @@ jobs:
context: Docker
file: ${{ matrix.base.dockerfile }}
platforms: linux/amd64,linux/arm64
tags: ${{ matrix.base.tags }}
cache-from: |
type=registry,ref=${{ matrix.base.tags }}
tags: ${{ matrix.base.tags }}
cache-from: |
type=registry,ref=${{ matrix.base.cache_tag }}
type=gha,scope=develop-base-${{ matrix.base.name }}
type=gha,scope=main-base-${{ matrix.base.name }}
${{ github.event.pull_request && format('type=gha,scope=pr-base-{0}-{1}', github.event.pull_request.number, matrix.base.name) || '' }}
Expand Down
Loading