Conversation
* Update docker hub readme task and fix version in README (#316) Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com> * Update GitHub Copilot guidance, enhance Docker build caching, and modify workspace settings (#318) * Update docker hub readme task and fix version in README (#316) (#317) Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com> * Update GitHub Copilot guidance, enhance Docker build caching, and modify workspace settings Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com> --------- Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com> --------- Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
…Docker builds Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
ptr727
added a commit
that referenced
this pull request
Feb 5, 2026
* Develop (#319) * Update docker hub readme task and fix version in README (#316) * Update GitHub Copilot guidance, enhance Docker build caching, and modify workspace settings (#318) * Update docker hub readme task and fix version in README (#316) (#317) * Update GitHub Copilot guidance, enhance Docker build caching, and modify workspace settings --------- --------- * Fix syntax in jq command for generating docker hub repositories (#320) * Update cache-to logic in Docker build step for feature branches (#321) * fix: Add cache_tag to base image definitions for improved caching in Docker builds --------- Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR enhances Docker build caching for base images by introducing an explicit cache_tag field in the base image matrix definitions, separating the concern of cache lookups from image tagging.
Changes:
- Added
cache_tagfield to bothnx-baseandnx-base-lsiobase image definitions in the GitHub Actions workflow - Updated the
cache-fromregistry reference to use the newcache_tagfield instead of the multi-linetagsfield
Comment on lines
+20
to
+29
| - name: nx-base | ||
| dockerfile: Docker/NxBase.Dockerfile | ||
| cache_tag: docker.io/ptr727/nx-base:ubuntu-noble | ||
| tags: | | ||
| docker.io/ptr727/nx-base:ubuntu-noble | ||
| - name: nx-base-lsio | ||
| dockerfile: Docker/NxBase-LSIO.Dockerfile | ||
| cache_tag: docker.io/ptr727/nx-base-lsio:ubuntu-noble | ||
| tags: | | ||
| docker.io/ptr727/nx-base-lsio:ubuntu-noble |
There was a problem hiding this comment.
The PR description mentions "Update the Docker Hub README and GitHub Copilot guidance for better clarity and usability" and "Fix syntax issues in the jq command for generating Docker Hub repositories", but these changes are not present in the diff. Either these changes were not included in this PR, or the PR description is inaccurate. Please ensure the PR description accurately reflects the actual changes included.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve Docker build caching by adding
cache_tagto base image definitions and updating the cache logic for feature branches. Additionally, update the Docker Hub README and GitHub Copilot guidance for better clarity and usability. Fix syntax issues in the jq command for generating Docker Hub repositories.