Conversation
Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the Docker build cache strategy for feature branches in the GitHub Actions workflow. Instead of using a generic "ro" cache scope for all non-main/develop branches, feature branches now use a per-image cache scope with the pattern feature-{imageName}.
Changes:
- Modified the
cache-toparameter for feature branches to useformat('type=gha,mode=min,scope=feature-{0}', matrix.images.Name)instead of the static'type=gha,mode=min,scope=ro'
ptr727
added a commit
that referenced
this pull request
Feb 5, 2026
…ld times and reduce GH actions cache utilization (#322) * Develop (#319) * Update docker hub readme task and fix version in README (#316) Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com> * Update GitHub Copilot guidance, enhance Docker build caching, and modify workspace settings (#318) * Update docker hub readme task and fix version in README (#316) (#317) Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com> * Update GitHub Copilot guidance, enhance Docker build caching, and modify workspace settings Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com> --------- Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com> --------- Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com> * Fix syntax in jq command for generating docker hub repositories (#320) Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com> * Update cache-to logic in Docker build step for feature branches (#321) Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com> * Refactor Docker build process and update base images - Removed the download script as it is no longer needed. - Updated build scripts to use `set -euo pipefail` for better error handling. - Created new base Dockerfiles for Nx Witness and Nx Witness LSIO using `ubuntu:noble` and `lsiobase/ubuntu:noble`. - Added GitHub Actions workflow for building base images with multi-platform support. - Updated Matrix.json to include new product branches and improved structure. - Enhanced README with details about the new base images and their purpose. Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com> * feat: Split docker images into base and product images to improve build times and reduce GH actions cache utilization chore: Update version to 2.10 in version.json and README.md fix: Ensure consistent formatting in Dockerfiles and scripts docs: Update HISTORY.md and README.md for version 2.10 release notes build: Enhance Build.sh to support pushing base images with inline cache metadata Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com> --------- Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
ptr727
added a commit
that referenced
this pull request
Feb 5, 2026
* Develop (#319) * Update docker hub readme task and fix version in README (#316) Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com> * Update GitHub Copilot guidance, enhance Docker build caching, and modify workspace settings (#318) * Update docker hub readme task and fix version in README (#316) (#317) Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com> * Update GitHub Copilot guidance, enhance Docker build caching, and modify workspace settings Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com> --------- Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com> --------- Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com> * Fix syntax in jq command for generating docker hub repositories (#320) Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com> * Update cache-to logic in Docker build step for feature branches (#321) Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com> * fix: Add cache_tag to base image definitions for improved caching in Docker builds Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com> --------- Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
ptr727
added a commit
that referenced
this pull request
Feb 5, 2026
* Develop (#319) * Update docker hub readme task and fix version in README (#316) * Update GitHub Copilot guidance, enhance Docker build caching, and modify workspace settings (#318) * Update docker hub readme task and fix version in README (#316) (#317) * Update GitHub Copilot guidance, enhance Docker build caching, and modify workspace settings --------- --------- * Fix syntax in jq command for generating docker hub repositories (#320) * Update cache-to logic in Docker build step for feature branches (#321) * fix: Add cache_tag to base image definitions for improved caching in Docker builds --------- Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.