Conversation
* Develop (#319) * Update docker hub readme task and fix version in README (#316) Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com> * Update GitHub Copilot guidance, enhance Docker build caching, and modify workspace settings (#318) * Update docker hub readme task and fix version in README (#316) (#317) Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com> * Update GitHub Copilot guidance, enhance Docker build caching, and modify workspace settings Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com> --------- Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com> --------- Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com> * Fix syntax in jq command for generating docker hub repositories (#320) Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com> * Update cache-to logic in Docker build step for feature branches (#321) Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com> * fix: Add cache_tag to base image definitions for improved caching in Docker builds Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com> --------- Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This pull request enhances Docker build caching by introducing a dedicated cache_tag field for base image definitions in the GitHub Actions workflow. The change improves maintainability by separating cache references from multi-line image tags, making the caching strategy more explicit and easier to manage.
Changes:
- Added
cache_tagfield to base image matrix definitions (nx-base and nx-base-lsio) - Updated
cache-fromdirective to use the newcache_tagfield instead of the multi-linetagsfield
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Develop (Develop #319)
Update docker hub readme task and fix version in README (Update docker hub readme task and fix version in README #316)
Update GitHub Copilot guidance, enhance Docker build caching, and modify workspace settings (Update GitHub Copilot guidance, enhance Docker build caching, and modify workspace settings #318)
Update docker hub readme task and fix version in README (Update docker hub readme task and fix version in README #316) (Update docker hub readme task and fix version in README (#316) #317)
Update GitHub Copilot guidance, enhance Docker build caching, and modify workspace settings
Fix syntax in jq command for generating docker hub repositories (Fix syntax in jq command for generating docker hub repositories #320)
Update cache-to logic in Docker build step for feature branches (Update cache-to logic in Docker build step for feature branches #321)
fix: Add cache_tag to base image definitions for improved caching in Docker builds