BF: remove onunhandledrejection but keep data-error#399
Open
tpronk wants to merge 1 commit intopsychopy:mainfrom
Open
BF: remove onunhandledrejection but keep data-error#399tpronk wants to merge 1 commit intopsychopy:mainfrom
tpronk wants to merge 1 commit intopsychopy:mainfrom
Conversation
Contributor
Author
|
I ran the wdio_video test on all our BrowserStack platforms; they all passed (including iOS). https://staging.psychopy.org/results_wdio/main/short/wdio_video/logs_processed/ |
Contributor
|
@tpronk @thewhodidthis This is a slightly tricky issue. onunhandledrejection is necessary to capture those errors that occurred in the various Promises we are now using. Removing it will prevent us from displaying those errors to participants, in a pop-up dialog window. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to PR #398, which keeps in the
data-errorpart inwindow.onerror, which is useful for our automated testing. As this testrun illustrates, this approach does seem to close #367 and close #397https://github.com/psychopy/psychojs/runs/2824210423?check_suite_focus=true
As @thewhodidthis did in his PR, I removed the
window.onunhandledrejection, but I'd like to check with @apitiot whether this might not cause other issues?