Skip to content

Comments

core/PsychoJS: restore _captureErrors#398

Closed
thewhodidthis wants to merge 1 commit intopsychopy:mainfrom
thewhodidthis:bf#397--error-handling
Closed

core/PsychoJS: restore _captureErrors#398
thewhodidthis wants to merge 1 commit intopsychopy:mainfrom
thewhodidthis:bf#397--error-handling

Conversation

@thewhodidthis
Copy link

@apitiot Closes #397 and closes #367

@tpronk
Copy link
Contributor

tpronk commented Jun 14, 2021

Is is necessary to remove the 'data-error' part?

@tpronk
Copy link
Contributor

tpronk commented Jun 14, 2021

It seems it's not necessary to remove the data-error part. I've made an alternative PR #399, which keeps it in, so I'll close this one.

@tpronk tpronk closed this Jun 14, 2021
@thewhodidthis thewhodidthis reopened this Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Changes brought in to help with #368 will break error handling on occasion Video component doesn't present

2 participants