Merged
Conversation
Mikefly123
previously approved these changes
Feb 7, 2025
Member
Mikefly123
left a comment
There was a problem hiding this comment.
LGTM! Great work putting this together Davit!
|
nateinaction
requested changes
Feb 7, 2025
Member
There was a problem hiding this comment.
Seeing some new errors in the flight control board. Thoughts on these?
{"hardware_key": "RTC", "msg": "Initializing hardware component", "time": "2020-01-01 00:01:55", "level": "DEBUG"}
{"time": "2020-01-01 00:01:55", "level": "ERROR", "err": ["'I2C' object has no attribute 'write'"], "hardware_key": "RTC", "msg": "There was an error initializing this hardware component"}
{"hardware_key": "SD Card", "msg": "Initializing hardware component", "time": "2020-01-01 00:01:55", "level": "DEBUG"}
{"time": "2020-01-01 00:01:57", "level": "ERROR", "err": ["no SD card"], "hardware_key": "SD Card", "msg": "There was an error initializing this hardware component"}
{"hardware_key": "NEOPIX", "msg": "Initializing hardware component", "time": "2020-01-01 00:01:57", "level": "DEBUG"}
{"hardware_key": "TCA", "msg": "Initializing hardware component", "time": "2020-01-01 00:01:57", "level": "DEBUG"}
{"time": "2020-01-01 00:01:57", "level": "ERROR", "err": ["Object has been deinitialized and can no longer be used. Create a new object."], "face": "Face0", "msg": "There was an Exception during the scan_tca_channels function call"}
{"time": "2020-01-01 00:01:57", "level": "ERROR", "err": ["Object has been deinitialized and can no longer be used. Create a new object."], "face": "Face1", "msg": "There was an Exception during the scan_tca_channels function call"}
{"time": "2020-01-01 00:01:57", "level": "ERROR", "err": ["Object has been deinitialized and can no longer be used. Create a new object."], "face": "Face2", "msg": "There was an Exception during the scan_tca_channels function call"}
{"time": "2020-01-01 00:01:57", "level": "ERROR", "err": ["Object has been deinitialized and can no longer be used. Create a new object."], "face": "Face3", "msg": "There was an Exception during the scan_tca_channels function call"}
{"time": "2020-01-01 00:01:57", "level": "ERROR", "err": ["Object has been deinitialized and can no longer be used. Create a new object."], "face": "Face4", "msg": "There was an Exception during the scan_tca_channels function call"}
For reference here's what main looks like:
{"hardware_key": "RTC", "msg": "Initializing hardware component", "time": "2020-01-01 00:05:07", "level": "DEBUG"}
{"hardware_key": "SD Card", "msg": "Initializing hardware component", "time": "2020-01-01 00:05:07", "level": "DEBUG"}
{"time": "2020-01-01 00:05:09", "level": "ERROR", "err": ["no SD card"], "hardware_key": "SD Card", "msg": "There was an error initializing this hardware component"}
{"hardware_key": "NEOPIX", "msg": "Initializing hardware component", "time": "2020-01-01 00:05:09", "level": "DEBUG"}
{"hardware_key": "TCA", "msg": "Initializing hardware component", "time": "2020-01-01 00:05:09", "level": "DEBUG"}
{"msg": "TCA try_lock failed. TCA may be malfunctioning.", "time": "2020-01-01 00:05:09", "level": "ERROR"}
{"msg": "PySquared Hardware Initialization Complete!", "time": "2020-01-01 00:05:09", "level": "DEBUG"}
{"time": "2020-01-01 00:05:09", "device": "I2C0", "level": "WARNING", "msg": "Unable to initialize hardware device", "status": false}
{"time": "2020-01-01 00:05:09", "device": "SPI0", "level": "INFO", "msg": "Successfully initialized hardware device", "status": true}
{"time": "2020-01-01 00:05:09", "device": "I2C1", "level": "INFO", "msg": "Successfully initialized hardware device", "status": true}
{"time": "2020-01-01 00:05:09", "device": "UART", "level": "INFO", "msg": "Successfully initialized hardware device", "status": true}
{"time": "2020-01-01 00:05:09", "device": "Radio1", "level": "INFO", "msg": "Successfully initialized hardware device", "status": true}
{"time": "2020-01-01 00:05:09", "device": "IMU", "level": "INFO", "msg": "Successfully initialized hardware device", "status": true}
{"time": "2020-01-01 00:05:09", "device": "Mag", "level": "INFO", "msg": "Successfully initialized hardware device", "status": true}
{"time": "2020-01-01 00:05:09", "device": "SDcard", "level": "WARNING", "msg": "Unable to initialize hardware device", "status": false}
{"time": "2020-01-01 00:05:09", "device": "NEOPIX", "level": "INFO", "msg": "Successfully initialized hardware device", "status": true}
{"time": "2020-01-01 00:05:09", "device": "WDT", "level": "WARNING", "msg": "Unable to initialize hardware device", "status": false}
{"time": "2020-01-01 00:05:09", "device": "TCA", "level": "WARNING", "msg": "Unable to initialize hardware device", "status": false}
{"time": "2020-01-01 00:05:09", "device": "Face0", "level": "WARNING", "msg": "Unable to initialize hardware device", "status": false}
{"time": "2020-01-01 00:05:09", "device": "Face1", "level": "WARNING", "msg": "Unable to initialize hardware device", "status": false}
{"time": "2020-01-01 00:05:09", "device": "Face2", "level": "WARNING", "msg": "Unable to initialize hardware device", "status": false}
{"time": "2020-01-01 00:05:09", "device": "Face3", "level": "WARNING", "msg": "Unable to initialize hardware device", "status": false}
{"time": "2020-01-01 00:05:09", "device": "Face4", "level": "WARNING", "msg": "Unable to initialize hardware device", "status": false}
{"time": "2020-01-01 00:05:09", "device": "RTC", "level": "INFO", "msg": "Successfully initialized hardware device", "status": true}
Member
|
Good catch @nateinaction I didn't actually have a board to run the code on as a test until a few minutes ago. I ran some tests myself and have a PR for fixing this issue as #7 on the We should probably block this merge for now until it is addressed. |
nateinaction
approved these changes
Feb 7, 2025
Contributor
Author
|
The new release of the rv3028 library fixes this issue! This is what it looks like now: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
This PR adds the proves-circuitpython-rv3028 repository as a library to the circuitpy-flight-software code. This PR will be ready once this pull request is approved and merged.
How was this tested
The code implemented by the rv3028 was tested with unit tests prior to submitting the PR. In addition, the library was brought on to this repository locally and tested on hardware, with no issues. The rv3028 library is successfully brought in with
makeand runs fine on the board.