Conversation
3 tasks
Contributor
|
Beat me to it by 7 minutes! I just found this issue as well. I'll take a look - looks like the tests need to be updated to use the corrected initialization as well |
added 2 commits
February 7, 2025 14:52
|
dbgen1
approved these changes
Feb 7, 2025
Contributor
dbgen1
left a comment
dbgen1
left a comment
There was a problem hiding this comment.
Looks good to me now! We can merge this and test it on the hardware.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on Nate's comments in #149 over in the
circuitpyrepo it looks like this library currently throws an error when it tries to initialize. I did some quick sleuthing and it looks like it is becauseI2CDeviceandaddresswere not being passed correctly in the__init__()function. I have fixed that in this PR and it looks like it is working again:NOTE: It looks like #4 has not been addressed yet and I needed to interrupt before being able to read from the
rtc.