Replace Pylint with Ruff linter #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been working with the Ruff toolchain for the last year or so at Enveritas. While I would prefer to have a toolchain that is entirely written in Python for use with Python code, the reality is 1) Ruff is a lot faster and 2) it's got a lot of momentum in the community.
The performance improvements don't make that much of a difference here, but there's a huge speedup for cedar-backup3, to the point where it's now practical again to lint the test suite — it was just too slow to be usable before. All by itself, that's worth the switch. Plus, there are a lot more linting rules available for Ruff. The Pylint rules are a subset of what Ruff offers, and I can pull in everything with one tool rather than integrating other tools alongside Pylint.
This PR includes only the framework changes necessary to migrate to the new linter. The actual fixes are in a follow-on PR. In this PR, every failing rule is explicitly excluded in
pyproject.toml, under the label Exclusions of specific rules that we want to work toward being compliant with.This work was prototyped in apologies PR #71.