Skip to content

Move to propshaft #2006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dczulada wants to merge 9 commits into
base: master
Choose a base branch
from

also include the duplicate change

ce1a468
Select commit
Loading
Failed to load commit list.
Draft

Move to propshaft #2006

also include the duplicate change
ce1a468
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 19, 2025 in 0s

77.17% (-18.77%) compared to 61b1e40

View this Pull Request on Codecov

77.17% (-18.77%) compared to 61b1e40

Details

Codecov Report

❌ Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.17%. Comparing base (61b1e40) to head (ce1a468).

Files with missing lines Patch % Lines
app/controllers/vendors_controller.rb 0.00% 2 Missing ⚠️
app/controllers/products_controller.rb 0.00% 1 Missing ⚠️
app/helpers/assets_helper.rb 94.73% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (61b1e40) and HEAD (ce1a468). Click for more details.

HEAD has 16 uploads less than BASE
Flag BASE (61b1e40) HEAD (ce1a468)
24 8
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #2006       +/-   ##
===========================================
- Coverage   95.94%   77.17%   -18.77%     
===========================================
  Files         158      159        +1     
  Lines        7169     7189       +20     
===========================================
- Hits         6878     5548     -1330     
- Misses        291     1641     +1350

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov