Skip to content

Conversation

@dczulada
Copy link
Contributor

@dczulada dczulada commented Dec 5, 2025

Pull requests into Cypress require the following. Submitter and reviewer should ✅ when done. For items that are not-applicable, note it's not-applicable ("N/A") and ✅.

Submitter:

  • This pull request describes why these changes were made.
  • Internal ticket for this PR:
  • Internal ticket links to this PR
  • Code diff has been done and been reviewed
  • Tests are included and test edge cases
  • Tests have been run locally and pass

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

❌ Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.17%. Comparing base (61b1e40) to head (ce1a468).

Files with missing lines Patch % Lines
app/controllers/vendors_controller.rb 0.00% 2 Missing ⚠️
app/controllers/products_controller.rb 0.00% 1 Missing ⚠️
app/helpers/assets_helper.rb 94.73% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (61b1e40) and HEAD (ce1a468). Click for more details.

HEAD has 16 uploads less than BASE
Flag BASE (61b1e40) HEAD (ce1a468)
24 8
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2006       +/-   ##
===========================================
- Coverage   95.94%   77.17%   -18.77%     
===========================================
  Files         158      159        +1     
  Lines        7169     7189       +20     
===========================================
- Hits         6878     5548     -1330     
- Misses        291     1641     +1350     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants