-
Notifications
You must be signed in to change notification settings - Fork 19
CI: rename build and run jobs #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
cd57566
CI: rename linux job and add run job for zephyr
SorinOlari 3012845
CI: fix path to zephyr.exe
SorinOlari 0222c42
CI: add executable permission for zephyr.exe
SorinOlari ba01f43
CI: cleanup
SorinOlari 4d10730
Merge branch 'main' into rename_CI_jobs
SorinOlari File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we shall discuss how we want to design this. We are back to sequential vs matrix run;
additionally, this workflow only works with native_sim and native_sim/64 targets, since we actually run the app. For the real-hardware devices other means will be necessary. Nevertheless, the high-level naming seems to be clear in this case.
Matrix builds give us more versability, but take longer in cases like this.
@casaroli wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P.S. Moreover, matrix is setup to accept new samples/boards, but the expected output is hardcoded; earlier we had that also as an input. If we are to go with matrices, we need to refactor them to be scalable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is ok. We will need to test different Zephyr builds, and this is the matrix for testing the native_sim (we can add the matrix later)