Conversation
Signed-off-by: SorinO <sorin.olari2@gmail.com>
Signed-off-by: SorinO <sorin.olari2@gmail.com>
Signed-off-by: SorinO <sorin.olari2@gmail.com>
Signed-off-by: SorinO <sorin.olari2@gmail.com>
|
|
||
| - name: Test native_sim mini | ||
| if: startsWith(matrix.board, 'native_sim/') && matrix.app == 'mini' | ||
| run-zephyr: |
There was a problem hiding this comment.
I think we shall discuss how we want to design this. We are back to sequential vs matrix run;
additionally, this workflow only works with native_sim and native_sim/64 targets, since we actually run the app. For the real-hardware devices other means will be necessary. Nevertheless, the high-level naming seems to be clear in this case.
Matrix builds give us more versability, but take longer in cases like this.
@casaroli wdyt?
There was a problem hiding this comment.
P.S. Moreover, matrix is setup to accept new samples/boards, but the expected output is hardcoded; earlier we had that also as an input. If we are to go with matrices, we need to refactor them to be scalable.
There was a problem hiding this comment.
I think it is ok. We will need to test different Zephyr builds, and this is the matrix for testing the native_sim (we can add the matrix later)
casaroli
left a comment
There was a problem hiding this comment.
I think I am missing something here.
We renamed the build workflow to "build and run", but then we removed the run step from the workflow?
If we separate the run into another workflow (I have doubts how useful this is), this workflow should only be called "build".
If we keep the run in this workflow, it should be renamed to "build and run".
Did I miss something?
casaroli
left a comment
There was a problem hiding this comment.
I think I am missing something here.
We renamed the build workflow to "build and run", but then we removed the run step from the workflow?
If we separate the run into another workflow (I have doubts how useful this is), this workflow should only be called "build".
If we keep the run in this workflow, it should be renamed to "build and run".
Did I miss something?
I realised these are different workflows. Please ignore my comment
Description
linux:
I changed the name from
build-linuxtobuild-and-runzephyr:
I decided to run the
minisample in a separate job dedicated to runtime tasks, using a matrix strategy. This approach allows us to easily extend the workflow in the future by adding new samples that need to be executed. The matrix can be improved by adding the expected log, but I don't think it's necessary until we add other test casesFixes issue # Rename CI jobs to clearly distinguish between build and build‑and‑run tasks #126
Type of change
Please delete options that are not relevant.
Checklist: