Skip to content

Use origin and embedded origin in permission key generation algorithm #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
annevk merged 3 commits into from
Oct 18, 2025
Merged

Use origin and embedded origin in permission key generation algorithm #233

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
38542ab
Align the spec with new permission key generation algorithm
jalonthomas Oct 16, 2025
28b5921
Use embeddedOrigin variable name
jalonthomas Oct 17, 2025
0243906
Update storage-access.bs
jalonthomas Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions storage-access.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,10 +399,10 @@ The Storage Access API defines a [=powerful feature=] identified by the [=powerf
</dd>
<dt>[=powerful feature/permission key generation algorithm=]</dt>
<dd>
To generate a new [=permission key=] for the "<a permission><code>storage-access</code></a>" feature, given an [=environment settings object=] |settings|, run the following steps:
To generate a new [=permission key=] for the "<a permission><code>storage-access</code></a>" feature, given an [=/origin=] |origin| and [=/origin=] |embeddedOrigin|:

1. Let |topLevelSite| be the result of [=obtain a site|obtaining a site=] from |settings|' [=environment/top-level origin=].
1. Let |embeddedSite| be the result of [=obtain a site|obtaining a site=] from |settings|' [=environment settings object/origin=].
1. Let |topLevelSite| be the result of [=obtain a site|obtaining a site=] from |origin|.
1. Let |embeddedSite| be the result of [=obtain a site|obtaining a site=] from |embeddedOrigin|.
1. Return (|topLevelSite|, |embeddedSite|).
</dd>
<dt>[=powerful feature/permission key comparison algorithm=]</dt>
Expand Down