Use origin and embedded origin in permission key generation algorithm#233
Merged
annevk merged 3 commits intoprivacycg:mainfrom Oct 18, 2025
Merged
Conversation
Collaborator
|
It was in fact modified in w3c/permissions#468 which also details the rationale. Using origins makes for an easier API for WebDriver. Given that this seems okay to me. |
annevk
reviewed
Oct 17, 2025
annevk
approved these changes
Oct 17, 2025
Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
Collaborator
|
Do you work for a company? If so, you want to talk to some standards people about resolving the IPR bot issue. If not, please say so and we'll need to discuss with someone from the W3C. |
Contributor
Author
|
I work for Google (added that to my profile) and requested to join the group yesterday afternoon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To align with the change to the permission key generation algorithm that was modified in w3c/permissions#468 (revised: w3c/permissions#469) to the Permissions spec, storage access api's algorithm should be updated to accept an origin and embedded origin, rather than an ESO.
Preview | Diff