Skip to content

Remove dead code from Go backend #3696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zackverham merged 2 commits into from
Mar 11, 2026
Merged

Remove dead code from Go backend #3696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5906d5d
Remove unused AppMode methods and NewManifestFileMap function
zackverham Mar 11, 2026
c66ebe4
Remove more dead code: proxy package, unused functions and methods
zackverham Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions internal/bundles/manifest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,10 +116,6 @@ type IntegrationRequest struct {
Config map[string]any `json:"config,omitempty"`
}

func NewManifestFileMap() ManifestFileMap {
return ManifestFileMap{}
}

type ManifestFile struct {
Checksum string `json:"checksum"`
}
Expand All @@ -135,26 +131,6 @@ func ReadManifest(r io.Reader) (*Manifest, error) {
return manifest, nil
}

// WriteManifest writes the manifest in JSON format.
func (m *Manifest) WriteManifest(w io.Writer) error {
manifestJSON, err := m.ToJSON()
if err != nil {
return err
}
_, err = w.Write(manifestJSON)
return err
}

// WriteManifestFile writes the manifest to a file.
func (m *Manifest) WriteManifestFile(path util.Path) error {
f, err := path.Create()
if err != nil {
return err
}
defer f.Close()
return m.WriteManifest(f)
}

func NewManifest() *Manifest {
return &Manifest{
Version: 1,
Expand Down
4 changes: 0 additions & 4 deletions internal/clients/connect/client_connect.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,6 @@ func (u *UserDTO) CanAdmin() bool {
return u.UserRole == AuthRoleAdmin
}

func (u *UserDTO) CanPublish() bool {
return u.UserRole == AuthRoleAdmin || u.UserRole == AuthRolePublisher
}

var errInvalidServerOrCredentials = errors.New("could not validate credentials; check connectivity to the server, the URL, and authentication credentials")
var errInvalidCredentials = errors.New("could not log in with the provided credentials")
var errInvalidServer = errors.New("could not access the server; check the server URL and try again")
Expand Down
125 changes: 0 additions & 125 deletions internal/clients/types/apptypes.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,101 +91,6 @@ func (mode *AppMode) UnmarshalText(text []byte) error {
return nil
}

// IsWorkerApp returns true for any content that is serviced by worker
// processes. This includes Shiny applications, interactive R Markdown
// documents, Plumber/Python (flask/fastapi) APIs, and Python apps
// (Dash, Streamlit, Bokeh, PyShiny, Voila, Gradio, Panel).
func (mode AppMode) IsWorkerApp() bool {
return (mode.IsShinyApp() ||
mode.IsPythonApp() ||
mode.IsAPIApp())
}

// IsAPIApp returns true for any API apps (currently, Plumber, Flask, or FastAPI).
func (mode AppMode) IsAPIApp() bool {
return mode.IsPlumberAPI() || mode.IsPythonAPI()
}

// IsPlumberAPI returns true for Plumber API applications.
func (mode AppMode) IsPlumberAPI() bool {
return mode == PlumberAPIMode
}

// IsPythonAPI returns true for Python API applications.
func (mode AppMode) IsPythonAPI() bool {
return mode == PythonAPIMode || mode == PythonFastAPIMode
}

// IsPythonApp returns true for Python applications (Dash, Streamlit, Bokeh, Voila)
func (mode AppMode) IsPythonApp() bool {
switch mode {
case PythonDashMode, PythonStreamlitMode, PythonGradioMode, PythonPanelMode, PythonShinyMode, PythonBokehMode, JupyterVoilaMode:
return true
}
return false
}

// IsShinyApp returns true for Shiny applications and interactive R Markdown
// documents.
func (t AppMode) IsShinyApp() bool {
return t == ShinyMode || t == ShinyRmdMode || t == ShinyQuartoMode
}

// IsDashApp returns true for Python Dash applications
func (t AppMode) IsDashApp() bool {
return t == PythonDashMode
}

// IsStreamlitApp returns true for Python Streamlit applications
func (t AppMode) IsStreamlitApp() bool {
return t == PythonStreamlitMode
}

// IsBokehApp returns true for Python Bokeh applications
func (t AppMode) IsBokehApp() bool {
return t == PythonBokehMode
}

// IsGradioApp returns true for Python Gradio applications
func (t AppMode) IsGradioApp() bool {
return t == PythonGradioMode
}

// IsPanelApp returns true for Python Panel applications
func (t AppMode) IsPanelApp() bool {
return t == PythonPanelMode
}

// IsFastAPIApp returns true for Python FastAPI applications
func (t AppMode) IsFastAPIApp() bool {
return t == PythonFastAPIMode
}

// IsPyShinyApp returns true for Python Shiny applications
func (mode AppMode) IsPyShinyApp() bool {
return mode == PythonShinyMode
}

// IsVoilaApp returns true for Python Voila interactive notebooks
func (mode AppMode) IsVoilaApp() bool {
return mode == JupyterVoilaMode
}

// IsStaticRmd returns true for any non-interactive R Markdown content.
func (mode AppMode) IsStaticRmd() bool {
return mode == StaticRmdMode
}

// IsStaticJupyter returns true for any non-interactive Jupyter content.
func (t AppMode) IsStaticJupyter() bool {
return t == StaticJupyterMode
}

// IsStaticReport returns true for any non-interactive R or Jupyter content.
func (t AppMode) IsStaticReport() bool {
return t == StaticRmdMode || t == StaticJupyterMode || t == StaticQuartoMode
}

// IsStaticContent returns true for any static content (deployed without
// source).
func (t AppMode) IsStaticContent() bool {
Expand All @@ -199,36 +104,6 @@ func (mode AppMode) IsKnown() bool {
return ok
}

// IsRContent returns true if R is the primary interpreter for this content
// type.
func (t AppMode) IsRContent() bool {
switch t {
case ShinyMode, ShinyRmdMode, StaticRmdMode, PlumberAPIMode:
return true
}
return false
}

// IsPythonContent returns true if Python is the primary interpreter for this
// content type.
func (t AppMode) IsPythonContent() bool {
switch t {
case StaticJupyterMode, PythonAPIMode, PythonDashMode, PythonStreamlitMode, PythonBokehMode, PythonFastAPIMode, PythonGradioMode, PythonPanelMode, PythonShinyMode, JupyterVoilaMode:
return true
}
return false
}

// IsQuartoContent return true if Quarto is the primary driver of this content
// type.
func (t AppMode) IsQuartoContent() bool {
switch t {
case ShinyQuartoMode, StaticQuartoMode:
return true
}
return false
}

func (t AppMode) Description() string {
switch t {
case UnknownMode:
Expand Down
Loading
Loading