Merged
Conversation
Remove 19 dead AppMode methods from internal/clients/types that were only exercised by tests but never called in production code. Also remove the unused NewManifestFileMap constructor (callers use make() directly). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Remove entire internal/services/proxy/ package (never imported) - Remove unused WriteManifest and WriteManifestFile from bundles/manifest.go - Remove unused CanPublish method from connect/client_connect.go - Remove unused NewOptional constructor from types/optional.go Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
zackverham
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AppModemethods frominternal/clients/types/apptypes.gothat were only exercised by tests but never called in production code (IsWorkerApp,IsShinyApp,IsDashApp,IsBokehApp, etc.)NewManifestFileMapconstructor frominternal/bundles/manifest.go(callers usemake(ManifestFileMap)directly)internal/services/proxy/package (never imported anywhere in the codebase)WriteManifestandWriteManifestFilemethods frominternal/bundles/manifest.go(never called)CanPublishmethod frominternal/clients/connect/client_connect.go(never called)NewOptional[T]constructor frominternal/types/optional.go(production code createsOptionalvalues via JSON unmarshal only)Test plan
go build ./internal/... ./cmd/...passesgo test -short ./internal/...passes (all 40+ packages)🤖 Generated with Claude Code