Migrate the assets of data store and source to Polypheny-DB#93
Open
malikrafsan wants to merge 4 commits intopolypheny:masterfrom
Open
Migrate the assets of data store and source to Polypheny-DB#93malikrafsan wants to merge 4 commits intopolypheny:masterfrom
malikrafsan wants to merge 4 commits intopolypheny:masterfrom
Conversation
Author
|
Hi @vogti I am sorry I think previous PR cannot be editted regarding the target branch. Therefore, I think we need to open a new PR. I would be more than happy to get your feedback, thank you so much!! |
datomo
approved these changes
Apr 14, 2024
Member
There was a problem hiding this comment.
Thank you @malikrafsan, this looks good.
After updating the branch this should be good to go.
Author
|
Thank you so much for your review @datomo ! But I think we need to merge this MR first, as this UI MR is introducing breaking changes on the icon and it dependent to this DB MR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In this pull request, we move the logos from stored at the Frontend (Polypheny-UI) to the Backend (Polypheny-DB). We also add the logo path/icon identifier on the response regarding Data Store and Data Source (
/getSnapshot). By doing this, we can simplify the process of adding new Data Stores / Data Sources by storing the logos in Polypheny-DB sources together with the adapter implementation.Fixes: #222
Changes
Related PRs
Screenshots
Asset files can be served by Polypheny-DB, under

/publichosted pathPolypheny-UI can access the Polypheny-DB static files and the Data Source and Data Store logos are shown successfully
