Migrate the assets of data store and source to Polypheny-DB#90
Migrate the assets of data store and source to Polypheny-DB#90malikrafsan wants to merge 1 commit intopolypheny:refactorfrom
Conversation
|
Hi @vogti , firstly, thank you so much for your review! Is there any reason why you close this PR? Is it because of the |
|
Hi @malikrafsan Sorry, the PR has automatically been closed because I merged the refactor branch. Please open the PR / change the target branch to master. Thank you for the PR, and sorry for the confusion. I did not realize that the PR has been closed. |
|
Hi @vogti No worries, no problem at all! I'll reopen the PR and adjust the target to the master branch. Looking forward to getting your feedback on the PR. Thank you so much!! |
|
it seems like I cannot change the target branch and reopen this PR. Therefore, I open a new PR for this, which can be accessed on here. Please let me know if you have any concern! Thank you! |
Summary
In this pull request, we move the logos from stored at the Frontend (Polypheny-UI) to the Backend (Polypheny-DB). We also add the logo path/icon identifier on the response regarding Data Store and Data Source (
/getSnapshot). By doing this, we can simplify the process of adding new Data Stores / Data Sources by storing the logos in Polypheny-DB sources together with the adapter implementation.Fixes: #222
Changes
Related PRs
Screenshots
Asset files can be served by Polypheny-DB, under

/publichosted pathPolypheny-UI can access the Polypheny-DB static files and the Data Source and Data Store logos are shown successfully
