Skip to content
This repository was archived by the owner on Feb 4, 2025. It is now read-only.

Conversation

@TomekIdczak97
Copy link

@TomekIdczak97 TomekIdczak97 commented Jul 17, 2019

Simple slab metrics unit test for pmem: test_metrics_evict_refcount


This change is Reviewable

@michalbiesek
Copy link

Please add information about stats which are not equal.

@TomekIdczak97
Copy link
Author

Please add information about stats which are not equal.

Assertion 'm1_buf == m2_buf' failed: m1_buf == "STATS item_curr 1", m2_buf == "STATS item_curr 0"

@michalbiesek
Copy link

@jschmieg FYI

The first check for statistics is in my opinion actually true.
You only reserve item there wasn't any insert operation yet - so the item isn't linked yet - after recreating items there are no way to distinguish this situation that item was only reserved

Second check for stats fails regarding slab request - I am not sure if this test is even correct.
I mean after teardown it should be NULLed

@TomekIdczak97
Copy link
Author

Failure - assertion message:
Saved:

STATS item_curr 1
STATS item_alloc 1

After restart:

STATS item_curr 0
STATS item_alloc 0

@TomekIdczak97 TomekIdczak97 force-pushed the test_metrics_evict_refcount branch from 20f4d39 to 6cb418b Compare July 24, 2019 13:57
@TomekIdczak97 TomekIdczak97 force-pushed the test_metrics_evict_refcount branch 3 times, most recently from 66cdc82 to a22d79c Compare August 12, 2019 06:42
@TomekIdczak97 TomekIdczak97 force-pushed the test_metrics_evict_refcount branch 5 times, most recently from be4402f to 36921c4 Compare August 20, 2019 15:51
@TomekIdczak97 TomekIdczak97 force-pushed the test_metrics_evict_refcount branch from 36921c4 to e48b040 Compare August 22, 2019 12:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants