Skip to content
This repository was archived by the owner on Feb 4, 2025. It is now read-only.

Conversation

@TomekIdczak97
Copy link

@TomekIdczak97 TomekIdczak97 commented Jul 19, 2019

Simple slab metrics unit test for pmem: test_metrics_delete_basic

Fail message:

Assertion 'm1_buf == m2_buf' failed: m1_buf == "STATS item_alloc 2", m2_buf == "STATS item_alloc 1"


This change is Reviewable

@michalbiesek
Copy link

Ref: #42 (comment)

@TomekIdczak97
I think

ck_assert_str_eq(m1_buf, m2_buf);

should be modified. Now you print only one stat which is different and there could be more than one stats different.

For the future please when you add comment in GitHub regarding statistics not directly from stdout but parse it to be more readable here:
Something like:

  • Before reset item_alloc was equal 2
  • After reset item_alloc was equal 1

@TomekIdczak97 TomekIdczak97 force-pushed the test_metrics_prepend_basic branch from 119e58a to a6ce062 Compare July 22, 2019 09:30
@TomekIdczak97
Copy link
Author

Failure - assertion message:
Saved:

STATS item_alloc 2
STATS item_dealloc 1
STATS item_link 2
STATS item_unlink 1

After restart:

STATS item_alloc 1
STATS item_dealloc 0
STATS item_link 1
STATS item_unlink 0

@TomekIdczak97 TomekIdczak97 force-pushed the test_metrics_prepend_basic branch from a6ce062 to 1d9442e Compare July 24, 2019 13:58
@TomekIdczak97 TomekIdczak97 force-pushed the test_metrics_prepend_basic branch 2 times, most recently from 5842933 to 0278840 Compare August 12, 2019 06:42
@TomekIdczak97 TomekIdczak97 force-pushed the test_metrics_prepend_basic branch 3 times, most recently from fc3077c to 0a8d96b Compare August 20, 2019 09:09
@TomekIdczak97 TomekIdczak97 force-pushed the test_metrics_prepend_basic branch from 0a8d96b to ca98632 Compare August 20, 2019 12:35
@TomekIdczak97 TomekIdczak97 force-pushed the test_metrics_prepend_basic branch from ca98632 to 58252d2 Compare August 20, 2019 15:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants