-
-
Notifications
You must be signed in to change notification settings - Fork 899
Add menu support to folder-contents breadcrumb for long navigation titles #7640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
d3ed44b
2d6af3b
2458a9d
fc88b4a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| import React from 'react'; | ||
| import { Icon } from '../Icon/Icon'; | ||
| import type { IconPropsWithoutChildren } from '../Icon/Icon'; | ||
|
|
||
| export const SlashIcon = (props: IconPropsWithoutChildren) => { | ||
| return ( | ||
| <Icon {...props}> | ||
| <svg | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| width="36" | ||
| height="36" | ||
| viewBox="0 0 36 36" | ||
| > | ||
| <polygon fillRule="evenodd" points="23 7 11 29 14 29 26 7" /> | ||
| </svg> | ||
| </Icon> | ||
| ); | ||
| }; |
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this condition for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To support replace instead of push behaviour.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in Link of react-aria-component you can pass options like replace and I want to support it that's why.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it actually used by the breadcrumbs? If not it should be in its own PR with its own entry in the release notes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davisagli Yes, if we don’t implement it in this PR, then folder-content navigation will not work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you see the pr I have added the routercontext so that client side navigation work for Link components of react-aria-components.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
link https://github.com/plone/volto/pull/7640/files#diff-b58a9be9f71dd1872f4e64518ed88f4ebb30163671f03c808a6cbe8329f4e084R92
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iFlameing Please add an entry of its own in this PR mentioning the new provider and what's for, I think the change is worth the effort.